Merged
Conversation
Signed-off-by: Laurent Rolaz <[email protected]>
Collaborator
|
you just need proper base instead of master |
Contributor
Author
|
@Slach sorry yes, I closed this to open another one properly based.... |
Collaborator
|
i changed the base, let's wait when e2e tests complete |
3 tasks
fix Helm release
Helm chart fix
Add helm local testing github actions
add missed runs-on for check_helm.yaml
Collaborator
|
@lorellalou could you sync your PR with 0.24.1 to re-run tests? or just something like "sync upstream" in github web interface |
add missed kubectl create namespace for check_helm.yaml
Contributor
Author
|
@Slach done. |
Slach
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for taking the time to contribute to
clickhouse-operator!Please, read carefully instructions on how to make a Pull Request.
This will help a lot for maintainers to adopt your Pull Request.
Important items to consider before making a Pull Request
Please check items PR complies to:
next-releasebranch, not intomasterbranch1. More info--
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into
masterbranch, but it has to be confirmed by project's maintainer.