fix: don't b64 encode configmap data#1540
Merged
Slach merged 1 commit intoAltinity:0.24.1from Oct 23, 2024
Merged
Conversation
Signed-off-by: Marvin Wolff <[email protected]>
Slach
approved these changes
Oct 23, 2024
Collaborator
|
nice catch, thanks for contribution |
Contributor
Author
|
@Slach Do you know when this is going to be released? |
Collaborator
|
we don't provide public ETA |
Contributor
Author
|
Hello @Slach, this is currently blocking our deployment, as we can't use the Dashboards. Could you take another look at this and maybe create a release? Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR the Dashboards were switched from secret to configmap, but the base64 encoding wasn't removed.
Also, a little bit of formatting was needed, as otherwise the deployment would fail.
Thanks for taking the time to contribute to
clickhouse-operator!Please, read carefully instructions on how to make a Pull Request.
This will help a lot for maintainers to adopt your Pull Request.
Important items to consider before making a Pull Request
Please check items PR complies to:
next-releasebranch, not intomasterbranch1. More info--
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into
masterbranch, but it has to be confirmed by project's maintainer.