Skip to content

Fix: Prevent CrashLoopBackOff during image upgrade with RollingUpdate (#1926) #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-zaitsev merged 1 commit into from
Apr 15, 2026
+6 −7
Merged

Fix: Prevent CrashLoopBackOff during image upgrade with RollingUpdate (#1926) #1956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions pkg/controller/chi/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,18 +175,17 @@ func (w *worker) shouldForceRestartHost(ctx context.Context, host *api.Host) boo
w.a.V(1).M(host).F().Info("Host has no ancestor, no restart applicable. Host: %s", host.GetName())
return false

// Check for image changes BEFORE checking RollingUpdate to avoid race condition
// where old image starts with new (potentially incompatible) config during upgrades
case w.isImageChangeRequested(host):
w.a.V(1).M(host).F().Info("Image change detected - deferring restart to STS rollout. Host: %s", host.GetName())
return false

case host.GetCR().IsRollingUpdate():
w.a.V(1).M(host).F().Info("RollingUpdate requires force restart. Host: %s", host.GetName())
return true

case model.IsConfigurationChangeRequiresReboot(host):
if w.isImageChangeRequested(host) {
// Image is also changing — skip pre-restart to avoid the race where the old image
// starts with the new (potentially incompatible) config. The STS rolling update
// will restart the pod with the correct image + config.
w.a.V(1).M(host).F().Info("Config change requires restart, but image is also changing - deferring restart to STS rollout. Host: %s", host.GetName())
return false
}
w.a.V(1).M(host).F().Info("Config change(s) require host restart. Host: %s", host.GetName())
return true

Expand Down
Loading