Skip to content

README: Update grafana-service (to be the same as grafana-operator name)#322

Merged
Slach merged 2 commits intoAltinity:masterfrom
wiktor2200:patch-1
Mar 30, 2020
Merged

README: Update grafana-service (to be the same as grafana-operator name)#322
Slach merged 2 commits intoAltinity:masterfrom
wiktor2200:patch-1

Conversation

@wiktor2200
Copy link
Copy Markdown
Contributor

@wiktor2200 wiktor2200 commented Mar 27, 2020

Grafana service name is changed when created using grafana-operator.
Here is this change in grafana-operator repo: https://github.com/integr8ly/grafana-operator/blob/master/pkg/controller/model/constants.go

@wiktor2200
README: Update grafana-service (to be the same as grafana-operator name)
8f1073c 
Grafana service name is changed when created using grafana-operator.
Here is this change in `grafana-operator` repo: https://github.com/integr8ly/grafana-operator/blob/master/pkg/controller/model/constants.go
@sunsingerus
Copy link
Copy Markdown
Collaborator

sunsingerus commented Mar 27, 2020

Ok, thanks!
We need to update Grafana's manual installation path as well

@sunsingerus sunsingerus self-assigned this Mar 27, 2020
@sunsingerus sunsingerus added the possible bug Something isn't working label Mar 27, 2020
@wiktor2200
Copy link
Copy Markdown
Contributor Author

wiktor2200 commented Mar 27, 2020

Manual grafana installation is not affected, because grafana service name is set here:

clickhouse-operator/deploy/grafana/grafana-manually/grafana.yaml

Line 69 in eda1163

name: grafana

So it's defined inside repo.

grafana-operator constants are defined in outer repo which I mentioned in PR description.
What is more it's been already fixed here:

Slach
Slach requested changes Mar 30, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Slach Slach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your efforts

could you also change https://github.com/Altinity/clickhouse-operator/blob/master/deploy/grafana/grafana-manually/grafana.yaml#L69

name: grafana
to
name: grafana-service

and change https://github.com/Altinity/clickhouse-operator/blame/master/docs/grafana_setup.md#L61
from

kubectl --namespace=grafana port-forward service/grafana 3000

to

kubectl --namespace=grafana port-forward service/grafana-service 3000

for name consistency

or just add write perimissions for @Slach in your fork ?

@wiktor2200
Copy link
Copy Markdown
Contributor Author

wiktor2200 commented Mar 30, 2020 •
edited by Slach
Loading

Sure. I will add it to my fork.

@wiktor2200
Copy link
Copy Markdown
Contributor Author

wiktor2200 commented Mar 30, 2020

@Slach I've changed it. I've found one more occurrence here: docs/k8s_cluster_access.md so I've changed it as well.

@Slach Slach added request for documentation Some detailed documentation/description is expected by topic starter from the project and removed possible bug Something isn't working labels Mar 30, 2020
@Slach Slach merged commit c8bac16 into Altinity:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Slach Slach Slach approved these changes

Assignees

@Slach Slach

@sunsingerus sunsingerus

Labels

request for documentation Some detailed documentation/description is expected by topic starter from the project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wiktor2200 @sunsingerus @Slach