Conversation
…omponent unit tests
… extend related tests
…eConverter`, and adjust related tests
…on and refactor `DefaultTypeConverter`. Update tests to align with new normalization logic.
…Character values fell through to subsequent type checks The first three `if` statements were not chained with `else`, causing: - null values to call setNull() then fall through to the else block calling setObject(position, null) - Character values to call setString() then fall through to the String/else-if chain
…() to stream close The configurationProvider.unsetQuery() was called in a finally block that executed immediately after returning the stream, before it was consumed. Now unsetQuery() runs in the stream's onClose handler alongside the ResultSet cleanup.
…ride methods The wrapContext method was an identity function, making the prepareQueryable and prepareSql overrides unnecessary pass-throughs to super.
- Test invalid enum name conversion throws IllegalArgumentException - Test canConvert() always returns true for the default converter - Test unrecognized types pass through unchanged - Test double-close of QueryContext throws IllegalStateException
…owing The Javadoc states it returns null on exception, but the implementation was throwing RuntimeException — identical to MethodFieldAccessor.
…nds access The resolveTypeVariable() loop always queried the initial typeVariable instead of currentTypeVariable, so type variable chains were never followed. Also added bounds array length check to prevent ArrayIndexOutOfBoundsException.
Previously, null values from the delegate accessor were passed directly to the converter method, causing NullPointerException. Now returns null without invoking the converter.
Adds AccessorTest (8 tests) covering MethodFieldAccessor, LaxMethodFieldAccessor, FieldFieldAccessor, and ConvertingFieldAccessor including null handling and error behavior. Adds DataFormatsTest (10 tests) covering beans convention, component method convention, fields convention, fields-via-method convention, nested objects, collections, maps, sub-filter exclusion, and accessor value correctness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.