540 deprecate DataCite schema 2 and 3#862
Merged
Conversation
sfisher
approved these changes
Apr 24, 2025
Contributor
sfisher
left a comment
There was a problem hiding this comment.
Thank you, Jing.
I like that you changed the name of the old functions to upgrade...v2 since it makes it clear which version to use it with in case we need it.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sfisher Hi Scott,
The major change is replacing the
upgradeDcmsRecord()function withupgradeDcmsRecord_v2().The
upgradeDcmsRecord_v2()function is derived fromupgradeDcmsRecord()with support of schema upgrade removed. The new function reports error if incoming record is not in schema version 4.The
upgradeDcmsRecord()function is kept for future reference in case backward version support is needed over the time.Test dataset and configuration are adjusted accordingly.
The updated code is deployed on ezid-stg with tag
test-datacite-drop-2-3_v2.Test results are documented in ticket: #540 (comment)
Please review and let me know if you have questions.
Thank you
Jing