Merged
Conversation
Merge Develop to main branch
Provide exlusion file from setting variables instead of command args Fix bugs on usage of internal values
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the link checker script to source its exclusion file configuration from the Django settings rather than the command line, and it updates internal variable references by prefixing them with self.
- Replace CLI argument handling for the exclusion file with configuration via Django settings
- Add self. prefixes to internal variables for consistency
Files not reviewed (1)
- settings/settings.py.j2: Language not supported
sfisher
approved these changes
May 7, 2025
Contributor
sfisher
left a comment
There was a problem hiding this comment.
Looks good to me and seems like a fairly straightforward change to use a known file location instead of having to pass it to the args.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sfisher Hi Scott,
Refactoring the link checker script includes:
self.to the internal variablesAlthough the link checker job itself is not tested, handling of the exclusion file was tested by running a paired test script on ezidui-dev. Here are the tested items:
Test results on handling of the exclusion file are documented in ticket #867 (comment)
The exclusion file
link_check_exclusion_list.txtis defined in the/ezid/var/datafolder in this format:Please review and let me know if you have any questions.
Thank you
Jing