Skip to content

863 update test datasets schema#891

Merged
jsjiang merged 24 commits intodevelopfrom
863_update_test-datasets-schema
Jun 23, 2025
Merged

863 update test datasets schema#891
jsjiang merged 24 commits intodevelopfrom
863_update_test-datasets-schema

Conversation

@jsjiang
Copy link
Copy Markdown
Contributor

@jsjiang jsjiang commented Jun 13, 2025

@sfisher Hi Scott,
Here are the major changes:

  1. Enabled schema validation for Crossref schema version 5.4

impl/crossref.py

- TAG_REGEX = re.compile("{(http://www\\.crossref\\.org/schema/(4\.[34]\.\d|5\.[3]\.\d))}([-\\w.]+)$")
+ TAG_REGEX = re.compile("{(http://www\\.crossref\\.org/schema/(4\.[34]\.\d|5\.[34]\.\d))}([-\\w.]+)$")
  1. Renamed the Linker Checker exclusion file to match the pattern used for exclusion by ID. Note: File linkchecker_user_exclusion_list.txt is already in place on the EZID instances.

settings/settings.py.j2

- LINKCHECKER_EXCLUSION_FILE = DATA_DIR / 'link_check_exclusion_list.txt'
+ LINKCHECKER_EXCLUSION_FILE = DATA_DIR / 'linkchecker_user_exclusion_list.txt'
  1. Enabled metadata type Crossref and DOI in the API testing loop. Current setting only tests DataCite and ARK.
  2. Updated DataCite test records to schema version 4
  3. Updated Crossref test records to schema version 5
  4. Removed unused test records with old schema versions
  5. Commented on not used and not implemented functions

Please take a look and let me know if you have questions.

Thank you

Jing

jsjiang and others added 23 commits June 4, 2025 11:47
@jsjiang
use datacite v4 sample record for testing
4e1cab3
@jsjiang
enable crossref testing
ed00a48
@jsjiang
use datacite sample record
7c03604
@jsjiang
add datacite, crossref, ARK and DOI combinations to TestAPI
a388a9f
@jsjiang
rename not implemented test case
bbc66da
@jsjiang
restore datacite_metadata.xml
807b1aa
@jsjiang
update crossref tests to use schema 5.4.0
9914f17
@jsjiang
save test record for crossref 4.4.0
64a9fed
@jsjiang
add test-doc datacite-example-full-v4.xml
c742189
@jsjiang
add sample files for comparing test results
cc7d3f0
@jsjiang
add comments to test cases
7a91618
@jsjiang
remove unused test file
21daf43
@jsjiang
renamed test file in newer pytest required format
e3fba77
@jsjiang
Remove not used test files
cba2d55 
These files are not used in current Pytest workflow.
Also, the error messages are derived from test records.
Recreate these test files when needed based on metadata schema.
@jsjiang
comment out not used fucntion
9722138
@jsjiang
add readme to explain test files for impl_util_to-exchange
e90d115
@jsjiang
reformat xml records for readability
15d75f9
@jsjiang
reformat xml records for readability
b3c2f40
@jsjiang
reformat test records to improve readability
02be169
@jsjiang
reformat test records to improve readability
46aad97
@jsjiang
Merge pull request #890 from CDLUC3/develop
abaced0 
Merge Develop to the main branch
@jsjiang
Merge branch 'main' into 863_update_test-datasets-schema
7af4773
@jsjiang
rename linkchecker exclusion file
8342585
@jsjiang jsjiang requested a review from sfisher June 13, 2025 17:13
sfisher
sfisher approved these changes Jun 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sfisher sfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Jing. These changes look good to me (new updated test data) and the renaming of the file. :-) 🎉

@jsjiang jsjiang mentioned this pull request Jun 23, 2025
Closed
@jsjiang jsjiang merged commit 95cfb58 into develop Jun 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfisher sfisher sfisher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jsjiang @sfisher