Merged
Conversation
Merge Develop to the main branch
Register filter to handle field name with hyphens Add relateditem template
Contributor
Author
|
@sfisher Hi Scott, can you take a look at the pull request when you have time. Jing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the major changes:
Changes to
datacite_xml.py:_repeatableElementContainersand form collecitonformColl_elementList_relatedItemto handle embedded elements with different topological order than what they appear at the element level.tests/test_datacite.pyChanges to
form_object.py:RelatedItemFormclassRelatedItemSetgetIdForm_datacite_xml()Changes to
jquery.formset.twobutton.js:clearFieldfunctionclearFieldfunctionaddButton.click(function()by clearing fields after clone the sub-form; otherwise the selected value of the last sub-form will stayOther changes:
_datacite_relatedItem.htmltest_datacite.pyto test form and Datacite XML data conversions:test_relateditem_form.pyto test the related item formget_fieldto access form field names with hyphens