Merged
Conversation
…doesn't screw up the entire visual layout (which it did for a while).
…ge on small screens.
…in very narrow screen.
…help popover for screen reader users.
… ChatGPT gave me info about what it thought was wrong and how to address the feedback
…ce the information is presented with aria-describedby
…ng odd css/svg display issue.
…the actual metadata entry. This seems to be what Andrew is asking for here.
… seemed as though div with role of group was supposed to be the same for accessiblility from what I understood, but they want it that way so changed it all. ¯\_(ツ)_/¯
jupiter007
approved these changes
Oct 23, 2025
Collaborator
jupiter007
left a comment
There was a problem hiding this comment.
Looks good to me. I only had a small comments, but it looks good.
…belledby is no longer necessary if they have embedded legend.
Contributor
Author
|
Made changes requested and merging. Thanks, @jupiter007 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly the same as previously but with these additional fixes in addition to the general things below based on what Andrew asked for:
role="group"provided mostly the same functionality for screen readers, but maybe there was some distinction that required this rework.Note: the dynamically generated mega-form with the add/remove sections and other things may not follow this same fieldset/legend pattern. He hadn't commented about it being a problem (and just being grouped as metadata), but if this becomes a concern then it may require quite a bit more rework for these sections and whatever dynamic stuff is going on may complicate things.
See the ticket #929 .
The help system should now be compatible with screen readers since it uses aria-describedby to point at the full help text when a screen encounters a help icon.
In addition to the checklist in the ticket there is a spreadsheet that Andrew shared with us for these. I don't want to put the link in this ticket, but would be happy to share the link privately (if it works, but Andrew may need to invite you also). Adam has this spreadsheet, also, since it's what he made the tickets from. Just go to the tab to see all issues and filter to show only medium-visiblity items.