Skip to content

DCOS cassandra#396

Merged
tayzlor merged 2 commits intomasterfrom
dcos-framework
Jul 17, 2015
Merged

DCOS cassandra#396
tayzlor merged 2 commits intomasterfrom
dcos-framework

Conversation

@enxebre
Copy link
Copy Markdown
Contributor

@enxebre enxebre commented Jul 17, 2015

No description provided.

tayzlor
tayzlor reviewed Jul 17, 2015
View reviewed changes
Comment thread roles/frameworks/templates/cassandra-config.j2
Copy link
Copy Markdown
Member

@tayzlor tayzlor Jul 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we expose the other config vars here or just leave it for now? https://github.com/mesosphere/universe/blob/version-1.x/repo/packages/C/cassandra/0/config.json

Copy link
Copy Markdown
Contributor

@wallies wallies Jul 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even expose the minimum required configuration values would be nice with the default in the config.json e.g.
"framework","cluster-name","zk-timeout-ms","node-count","seed-count","health-check-interval-seconds","bootstrap-grace-time-seconds","data-directory","resources"

Copy link
Copy Markdown
Member

@tayzlor tayzlor Jul 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be a follow-up issue

@tayzlor
Copy link
Copy Markdown
Member

tayzlor commented Jul 17, 2015

👍 really like this PR!

@wallies
Copy link
Copy Markdown
Contributor

wallies commented Jul 17, 2015

very nice 👍

wallies
wallies reviewed Jul 17, 2015
View reviewed changes
Comment thread roles/frameworks/defaults/main.yml Outdated
Copy link
Copy Markdown
Contributor

@wallies wallies Jul 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we going to enable this by default. all frameworks except marathon should be disabled by default i think

Copy link
Copy Markdown
Contributor Author

@enxebre enxebre Jul 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups no, was testing

tayzlor added a commit that referenced this pull request Jul 17, 2015
@tayzlor
Merge pull request #396 from Capgemini/dcos-framework
8fdb938 
DCOS cassandra
@tayzlor tayzlor merged commit 8fdb938 into master Jul 17, 2015
@tayzlor tayzlor deleted the dcos-framework branch July 17, 2015 10:33
This was referenced Jul 20, 2015
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@enxebre @tayzlor @wallies