Skip to content

Dargon789 patch 9#206

Open
Dargon789 wants to merge 4 commits intomainfrom
Dargon789-patch-9
Open

Dargon789 patch 9#206
Dargon789 wants to merge 4 commits intomainfrom
Dargon789-patch-9

Conversation

@Dargon789
Copy link
Copy Markdown
Owner

@Dargon789 Dargon789 commented Apr 5, 2026 •
edited by sourcery-ai Bot
Loading

Summary by Sourcery

Optimize hook execution and adjust release workflow triggers.

Enhancements:

  • Use command.status() instead of command.output() for hook execution to avoid unnecessary output buffering.

CI:

  • Update release workflow to trigger only on pushes to the master branch.

Documentation:

  • Add a changeset entry describing the hook execution behavior change.

Dargon789 and others added 4 commits January 29, 2026 01:48
@Dargon789
Remove 'main' branch from release workflow triggers
db110ab 
Signed-off-by: Dargon789 <[email protected]>
@Dargon789
Add changeset for Dargon789 patch 9 (#116)
992a0e9 
Chores:

Record a patch release note for fnm attributed to Dargon789 patch 9.
Signed-off-by: Dargon789 <[email protected]>
@Dargon789 @gemini-code-assist
Update src/hooks.rs
85168f6 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <[email protected]>
@Dargon789 @gemini-code-assist
Update .changeset/popular-falcons-grab.md
2a7eca1 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <[email protected]>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fnm Ready Ready Preview, Comment Apr 5, 2026 2:30pm

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 5, 2026 •
edited
Loading

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors hook execution to use process exit status without buffering output, adjusts the release workflow branches, and documents the change via a changeset entry.

File-Level Changes

Change Details Files
Use process status instead of capturing full output when executing hooks to avoid unnecessary output buffering and keep stderr/stdout streaming directly to the user.
  • Replace command.output() with command.status() when running hooks
  • Check success on the returned ExitStatus instead of on Output.status
  • Propagate the exit code from the ExitStatus when constructing HookExecutionFailed errors
 src/hooks.rs
Restrict the release GitHub Actions workflow to trigger only on pushes to the master branch.
  • Remove main branch from the list of branches that trigger the release workflow
 .github/workflows/release.yml
Record the change as a patch-level update in the project’s changeset system.
  • Add a changeset noting the switch from command.output() to command.status() for hook execution
 .changeset/popular-falcons-grab.md
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Apr 5, 2026

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@Dargon789 Dargon789 enabled auto-merge (squash) April 5, 2026 14:30
sourcery-ai[bot]
sourcery-ai Bot reviewed Apr 5, 2026
View reviewed changes
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Dropping the main branch from the release workflow trigger narrows when releases are built; double-check that this is intentional and that no active branches rely on the previous behavior.
Prompt for AI Agents 
Please address the comments from this code review:

## Overall Comments
- Dropping the `main` branch from the release workflow trigger narrows when releases are built; double-check that this is intentional and that no active branches rely on the previous behavior.

Fix all in Cursor

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 5, 2026

⚠️ The sha of the head commit of this PR conflicts with #203. Mergify cannot evaluate rules on this PR. Once #203 is merged or closed, Mergify will resume processing this PR. ⚠️

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 5, 2026
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the hook execution logic in src/hooks.rs to use command.status() instead of command.output(), which prevents unnecessary memory buffering of the command's output. A corresponding changeset has also been added. I have no feedback to provide.

@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 13, 2026

⚠️ The sha of the head commit of this PR conflicts with #203. Mergify cannot evaluate rules on this PR. Once #203 is merged or closed, Mergify will resume processing this PR. ⚠️

@Dargon789 Dargon789 linked an issue Apr 15, 2026 that may be closed by this pull request
Sequence diagram for fnm env --use-on-cd eager initial use #215
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sequence diagram for fnm env --use-on-cd eager initial use

1 participant

@Dargon789