Skip to content

Update ci.yml #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dargon789 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ci.yml #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: 2.1
jobs:
build-and-test:
docker:
- image: cimg/rust:1.88.0
- image: cimg/rust:1.89.0
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The rust-toolchain.toml file specifies the Rust channel as 1.89. Pinning the Docker image to 1.89.0 may cause rustup to download a newer patch version at runtime if one is available, increasing build time. Consider using the 1.89 tag to stay in sync with the toolchain.

Additionally, the 'Check formatting' and 'Run tests' steps are redundantly duplicated in this job (lines 13-18 and 27-32) and should be removed to improve CI efficiency. Also, note that without a workflows section, CircleCI expects a job named build rather than build-and-test to execute the pipeline.

      - image: cimg/rust:1.89

steps:
- checkout
- restore_cache:
Expand Down
Loading