Fix stored XSS→RCE in OfflineCause.UserCause and auth bypass in RunParameterValue#4
Draft
Fix stored XSS→RCE in OfflineCause.UserCause and auth bypass in RunParameterValue#4
Conversation
…ParameterValue authorization bypass) Co-authored-by: DominicBreuker <[email protected]>
Co-authored-by: DominicBreuker <[email protected]>
Co-authored-by: DominicBreuker <[email protected]>
Copilot
AI
changed the title
[WIP] Fix critical remote code execution vulnerability
Fix stored XSS→RCE in OfflineCause.UserCause and auth bypass in RunParameterValue
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports SECURITY-3669 and SECURITY-3658 fixes missing from this fork (upstream patched 2026-02-15, fork base is 2026-02-10).
SECURITY-3669: Stored XSS → RCE via OfflineCause.UserCause
UserCause.toString()andgetMessage()rendered user-controlled offline messages without HTML escaping. Any user withComputer.DISCONNECT(granted to all authenticated users under "Logged-in users can do anything") can inject persistent XSS that fires when an admin views any node page, chaining to RCE via/script:Fix: Wrap both methods with
Util.escape():CVSS 8.8 — AV:N/AC:L/PR:L/UI:R/S:U/C:H/I:H/A:H
SECURITY-3658: Authorization bypass in RunParameterValue
RunParameterValueaccepted arbitraryrunIdvalues without verifying the referenced run exists or is accessible. Users withItem.BUILDon one project could reference builds in projects they lackItem.READon, leaking display names, URLs, and results via environment variables.Fix: Added existence check via
Run.fromExternalizableId()in constructor, which respects ACL. Escape hatch:-Dhudson.model.RunParameterValue.SKIP_EXISTENCE_CHECK=true.Changes
OfflineCause.java— HTML-escapeUserCause.toString()andgetMessage()RunParameterValue.java— Validate referenced run exists and is accessible at construction timeOfflineCauseTestwith XSS escaping assertionsRunParameterValueTestto account for existence check; addedRunParameterValueIntegrationTestwith@WithJenkinsWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
repo.jenkins-ci.org/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -Xmx1400m -classpath /usr/share/apache-maven-3.9.12/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.12/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.12 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.12/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/jenkins/jenkins org.codehaus.plexus.classworlds.launcher.Launcher test -pl core -Dtest=hudson.slaves.OfflineCauseTest -DfailIfNoTests=false -q ic void doScriptsh java/jenkins/mod-c(dns block)www.jenkins.io/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.