support for saving and loading pnets and vnets#40
Merged
GeminiLight merged 1 commit intoGeminiLight:mainfrom May 16, 2025
Merged
support for saving and loading pnets and vnets#40GeminiLight merged 1 commit intoGeminiLight:mainfrom
GeminiLight merged 1 commit intoGeminiLight:mainfrom
Conversation
Owner
|
Hi @reills Thank you so much for your positive feedback and for implementing these updates! These new features you've added are super helpful, particularly in saving and loading datasets. I’ve gone through the PR and tested the features—it all looks great! I’ll go ahead and merge this now, and if needed, make any adjustments in future updates. At the moment, I’m working on adding more tests, refining the documentation, and polishing the benchmarking paper to make Virne even easier to use and contribute to. Thanks again for your great contribution! |
Contributor
Author
|
really love this project! thanks for all the time you have spent on it. |
luismomm2110
pushed a commit
to luismomm2110/virne
that referenced
this pull request
Jan 3, 2026
support for saving and loading pnets and vnets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @GeminiLight ,
Congrats on releasing version 1.0! It looks really good and is very clean. One thing that's been helpful for me is being able to save and load p_net.gml, v_net.gml files so I can better debug and investigate.
In the PR, I added config variables in main.yaml to allow for that. They do:
if_save_pnet: if true, save pnet to the save_root_dir under the generated name.
if_save_vnet: if true, save the vnets to the save_root_dir under the generated name
if_load_pnet: if true, load the pnet from the save root with the generated name
if_load_vnet: if true, load the vnet from the save root with the generated name
Load vnet is cached after the first run so that for the following runs it is not regenerated. Also, since the vnet is generated on reset I figured maybe it might be useful to save only the first generated vnet. Not sure if this is what you had in mind for how a save/load flow would look like, but that seemed most practical to me.
I tried to keep the changes minimal and non-intrusive. Let me know if this seems useful and I’m happy to make updates :)