Improved bitcoind onion-grater profile#7
Open
ApacheSub wants to merge 1 commit intoWhonix:masterfrom
Open
Conversation
…XX:8334=onion to be used and will allow bitcoin-cli netinfo to display onion inbound connections correctly instead of being displayed as npr.
Author
|
I've found a typo. On each line with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is infact not necessary to use
bind=0.0.0.0:8334=onionin bitcoind.conf. It is only necessary with the current version of the profile. I've added support to usebind=10.152.152.XX:8334=onion. When0.0.0.0is used,bitcoin-cli -netinfoincorrectly displays incoming onion connections as npr. I've tested this profile and it will classify them correctly after the change. I assume the problem is binding to0.0.0.0.I also fixed the fact that dots are not being escaped in the patterns.
Please be mindful of any typos.