WIP (no review yet): update etcd + GRPC deps.#4074
Closed
andrewmains12 wants to merge 15 commits intomasterfrom
Closed
WIP (no review yet): update etcd + GRPC deps.#4074andrewmains12 wants to merge 15 commits intomasterfrom
andrewmains12 wants to merge 15 commits intomasterfrom
Conversation
``` % go mod edit -dropreplace google.golang.org/grpc % go mod download ```
``` % go mod edit \ -dropreplace go.etcd.io/etcd/server/v3 \ -replace=go.etcd.io/etcd/server/v3=go.etcd.io/etcd/server/v3@main % go mod download ```
We did this on go-code also: ``` % go mod edit \ -replace=github.com/envoyproxy/go-control-plane=github.com/envoyproxy/[email protected] ```
``` % go mod edit \ -dropreplace go.etcd.io/etcd/pkg/v3 \ -replace=go.etcd.io/etcd/pkg/v3=go.etcd.io/etcd/pkg/v3@main % go mod edit \ -replace=google.golang.org/grpc=google.golang.org/[email protected] & go mod tidy ```
```
% go mod edit \
-droprequire=go.etcd.io/etcd/server/v3 \
-require=go.etcd.io/etcd/server/[email protected]
```
``` go get go.etcd.io/etcd/api/v3 go get go.etcd.io/etcd/client/pkg/v3 go mod tidy ```
go mod edit -dropreplace go.etcd.io/etcd/server/v3
Replace everything to bleeding edge etcd +replace go.etcd.io/etcd/server/v3 => go.etcd.io/etcd/server/v3 v3.5.0-alpha.0.0.20220215220652-e814f6f78a12 + +replace go.etcd.io/etcd/client/v3 => go.etcd.io/etcd/client/v3 v3.5.0-alpha.0.0.20220215220652-e814f6f78a12 + +replace go.etcd.io/etcd/api/v3 => go.etcd.io/etcd/api/v3 v3.5.0-alpha.0.0.20220215220652-e814f6f78a12 + +replace go.etcd.io/etcd/client/pkg/v3 => go.etcd.io/etcd/client/pkg/v3 v3.0.0-20220215220652-e814f6f78a12
|
|
zmt
reviewed
Mar 4, 2022
Comment on lines
+94
to
+98
| // go.opentelemetry.io/otel/bridge/opentracing v1.0.0-RC2 | ||
| // go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.0.0-RC2 | ||
| // go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.0.0-RC2 | ||
| // go.opentelemetry.io/otel/internal/metric v0.22.0 // indirect | ||
| // go.opentelemetry.io/otel/sdk v1.0.0-RC2 |
Contributor
There was a problem hiding this comment.
I forgot to delete the commented lines.
Manually drop all etcd replaces. ``` go mod edit -replace=go.etcd.io/etcd/client/v2=go.etcd.io/etcd/client/[email protected] go get go.etcd.io/etcd/api/[email protected] \ go.etcd.io/etcd/client/pkg/[email protected] \ go.etcd.io/etcd/client/[email protected] \ go.etcd.io/etcd/server/[email protected] \ go.etcd.io/etcd/tests/[email protected] ```
09cad8f to
4f141f7
Compare
Contributor
Author
|
Closing this for now in favor of #4087 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR to update GRPC + etcd; very subject to change.