add docker compose for new crawler#241
Merged
daoudclarke merged 2 commits intomwmbl:mainfrom May 30, 2025
Merged
Conversation
f4e119f to
467f217
Compare
Signed-off-by: thiswillbeyourgithub <[email protected]>
Signed-off-by: thiswillbeyourgithub <[email protected]>
467f217 to
656b852
Compare
Contributor
|
Hey, thanks so much for this!
|
Contributor
Author
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the issue thread #45
After using it for a few hour there are a few things I noticed:
1.1. I don't think it's good for the hardware, especially consumer level.
1.2.
Couldn't we use async to crawl, pull and push in parallel?Edit: reading the code it seems to be already async.1.3. I fear that for customer hardware this would cause an annoying alternation between full fan and quiet.
crawlerv1orcrawlerv2because it's very confusing right now. There is a github repo, a docker image, a "command line crawler" etc. TheDockerfile.crawleris not even inmwmbl-crawlerrepo :). Apparently something is getting ported to rust but is still not there so it's still impossible to know which is which. I also think you should write in text related tocrawlerv1that the v2 is in the works: you are not particularly proud of how the v1 works so you don't want to let newcomers think that you haven't noticed its shortcomings.That's it for me. What do you think about all this?
Also could you clearly state the location where the code for that new crawler code resides? I might have a go at improving it a bit, especially for the async part depending on how the code is done. Edit: well actually it's just
./mwmbl/crawlI think, really confusing IMO :)