Fix heap buffer overflow in BEXT metadata parser (CVE-2026-32837)#1115
Open
deekshaNVIDIA wants to merge 1 commit intomackron:devfrom
Open
Fix heap buffer overflow in BEXT metadata parser (CVE-2026-32837)#1115deekshaNVIDIA wants to merge 1 commit intomackron:devfrom
deekshaNVIDIA wants to merge 1 commit intomackron:devfrom
Conversation
The BEXT coding history parser allocates extraBytes+1 bytes (the +1 for a null terminator) then reads extraBytes from the file, but never writes the null terminator. The subsequent ma_dr_wav__strlen() call scans past the buffer into uninitialized heap memory, causing an unbounded out-of-bounds read. Null-terminate the buffer at the actual bytes-read position and use the byte count directly for codingHistorySize, eliminating the unsafe strlen call entirely. Fixes mackron#1101
b6ff990 to
a12a6ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BEXT coding history parser allocates
extraBytes + 1bytes (the +1 for a null terminator) then readsextraBytesfrom the file, but never writes the null terminator. The subsequentma_dr_wav__strlen()call scans past the buffer into uninitialized heap memory, causing an unbounded out-of-bounds read.Null-terminate the buffer at the actual bytes-read position and use the byte count directly for
codingHistorySize, eliminating the unsafestrlencall entirely.Fixes #1101