Skip to content

Make ma_android_sdk_version static#1116

Merged
mackron merged 1 commit intomackron:devfrom
ykhrustalev:fix/android-sdk-version-static
Apr 25, 2026
Merged

Make ma_android_sdk_version static#1116
mackron merged 1 commit intomackron:devfrom
ykhrustalev:fix/android-sdk-version-static

Conversation

@ykhrustalev
Copy link
Copy Markdown

@ykhrustalev ykhrustalev commented Apr 15, 2026

Fails to build on Android NDK with -Wmissing-prototypes -Werror:

error: no previous prototype for function 'ma_android_sdk_version'

The function is only used within the implementation block, so static matches every other helper there (ma_has_sse2, ma_has_neon, …). No behavioral change.

Found via ggml-org/llama.cpp#21647.

@ykhrustalev ykhrustalev force-pushed the fix/android-sdk-version-static branch from b3c56f1 to febfa2f Compare April 15, 2026 16:34
@ykhrustalev ykhrustalev changed the base branch from master to dev April 15, 2026 16:34
@ykhrustalev ykhrustalev changed the title Make ma_android_sdk_version static to silence -Wmissing-prototypes Make ma_android_sdk_version static Apr 15, 2026
@mackron mackron merged commit 56ffd77 into mackron:dev Apr 25, 2026
@mackron
Copy link
Copy Markdown
Owner

mackron commented Apr 25, 2026

Thanks. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants