Open
Conversation
2bdec2f to
627a329
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think pulling telnet into the mininet installation is unnecessary, as we can also solve this by using netcat.
Regarding the featureset and areas of usage, netcat seems to be better suited than telnet to do the job and feels like it's more useful to have inside the mininet processes.
I tested the examples
cpu.pyandlinearbandwidth.pyas those are directly affected by this change.They both passed.
Also,
mininet/test/test_walkthrough.pypasses without regression on ubuntu 20.04 (after installing the packagepython-is-python3.