Replace triomphe::Arc with our own MiniArc type#47
Open
tatsuya6502 wants to merge 3 commits intov0.11.xfrom
Open
Replace triomphe::Arc with our own MiniArc type#47tatsuya6502 wants to merge 3 commits intov0.11.xfrom
triomphe::Arc with our own MiniArc type#47tatsuya6502 wants to merge 3 commits intov0.11.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a private
MiniArctype. It is a minimal implementation of atomic reference counted shared pointer. It is like astd::sync::Arcandtriomphe::Arcbut with a few differences:Weakreferences, soMiniArcdoes not have the weak reference counter.AtomicU32instead ofAtomicUsizefor the strong reference counter.mokaandmini-moka.MiniArcreplaces alltriomphe::Arcusages inmoka.On the CI (GitHub Actions), the following tests are performed in addition to the regular tests:
MiniArc.MiniArc.