feat: add js feature and wasm support via web_time crate#50
Open
niclashoyer wants to merge 1 commit intomoka-rs:v0.11.xfrom
Open
feat: add js feature and wasm support via web_time crate#50niclashoyer wants to merge 1 commit intomoka-rs:v0.11.xfrom
niclashoyer wants to merge 1 commit intomoka-rs:v0.11.xfrom
Conversation
Author
|
On a side note: it may be possible to transparently support wasm by using |
|
I am also looking for wasm support from moka and found this PR. I think it can be compiled to different targets based on #[cfg(not(all(target_arch = "wasm32", target_os = "unknown")))]
pub use std::time::{Instant, SystemTime};
#[cfg(all(target_arch = "wasm32", target_os = "unknown"))]
pub use web_time::{Instant, SystemTime}; |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds experimental support for wasm/js using the
web_timecrate.As wasm32-unknown-unknown does not directly support threads, I had problems getting
syncto compile. So this currently just works for unsync.A new feature
jsis introduced that enables the necessary dependencies. Tests need to be run withwasm-pack:wasm-pack test --node --no-default-features --features js