Skip to content

MOTOR-1420 Add detailed return type to to_list method#316

Merged
blink1073 merged 1 commit intomongodb:masterfrom
SaidBySolo:patch-1
Jan 13, 2025
Merged

MOTOR-1420 Add detailed return type to to_list method#316
blink1073 merged 1 commit intomongodb:masterfrom
SaidBySolo:patch-1

Conversation

@SaidBySolo
Copy link
Copy Markdown
Contributor

@SaidBySolo SaidBySolo commented Jan 11, 2025

My type checker complains that there is an unknown type in the list.
I opened this PR because it seemed better to return Any rather than Unknown.

@SaidBySolo SaidBySolo changed the title Add return type to to_list method Add detailed return type to to_list method Jan 11, 2025
Copy link
Copy Markdown
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 changed the title Add detailed return type to to_list method MOTOR-1420 Add detailed return type to to_list method Jan 13, 2025
@blink1073 blink1073 merged commit 777d2aa into mongodb:master Jan 13, 2025
@SaidBySolo SaidBySolo deleted the patch-1 branch January 13, 2025 16:29
@SaidBySolo
Copy link
Copy Markdown
Contributor Author

Thank you for maintaining library! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants