nixpkcs.sh: support destroyOld and softFail, and turn off renewal by default#20
Merged
nixpkcs.sh: support destroyOld and softFail, and turn off renewal by default#20
Conversation
If destroyOld is set to true, the old key will be destroyed upon renewal.
For tokens that are removable (e.g. a Yubikey) we may not want to fail the systemd service if the token is missing. If we fail to probe the token, don't fetch the certificate but also don't fail if softFail is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a little safer and less likely to create weird situations involving multiple keys bound to the same ID.