Removed bowtie2 alignments from .command.out#101
Merged
skrakau merged 2 commits intonf-core:devfrom Sep 11, 2020
Merged
Conversation
d4straub
approved these changes
Sep 11, 2020
Collaborator
d4straub
left a comment
There was a problem hiding this comment.
Looks good to me, would it make sense to add that to the CHANGELOG.md as well (since it is a bug in 1.0.0)?
Member
Author
|
Thanks @d4straub ! I thought it doesn't really change the user interface, but it does effect the size so I added it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #97.
Redirected
bowtie2 stdout, i.e. alignments, to/dev/nullandbowtie2 stderrtologfile. Thelogfile is not written toresultsas${name}_remove_phix.logcovers already the important stats.Also I couldn't resist to rename
${name}_remove_phix_log.txtto${name}_remove_phix.log. I saw there more such named files, but I would rename them in a separate PR, if you don't mind :)PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: https://github.com/nf-core/mag/tree/master/.github/CONTRIBUTING.md