Skip to content

Fix seaborn version to avoid error with nanoplot#118

Merged
skrakau merged 1 commit intonf-core:devfrom
skrakau:test_nanoplot_seaborn
Oct 14, 2020
Merged

Fix seaborn version to avoid error with nanoplot#118
skrakau merged 1 commit intonf-core:devfrom
skrakau:test_nanoplot_seaborn

Conversation

@skrakau
Copy link
Copy Markdown
Member

@skrakau skrakau commented Oct 14, 2020

On some long read data, I got a NanoPlot error:

raise AttributeError(f"{type(self).__name__!r} object "
AttributeError: 'PathCollection' object has no property 'stat_func'

See alos wdecoster/NanoPlot#201.

Seems there was recently a new seaborn version 0.11.0 released, which can cause problems with NanoPlot. They fixed the seaborn version in the current bioconda recipe. But since we use an older NanoPlot version, we need to fix this manually within the environment.yml.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repo

@skrakau skrakau requested a review from d4straub October 14, 2020 14:57
Copy link
Copy Markdown
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skrakau skrakau merged commit fbf90a0 into nf-core:dev Oct 14, 2020
@skrakau skrakau deleted the test_nanoplot_seaborn branch May 31, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants