Skip to content

Add Prokka#245

Merged
AntoniaBeller merged 11 commits intonf-core:devfrom
AntoniaBeller:prokka
Nov 3, 2021
Merged

Add Prokka#245
AntoniaBeller merged 11 commits intonf-core:devfrom
AntoniaBeller:prokka

Conversation

@AntoniaBeller
Copy link
Copy Markdown
Contributor

@AntoniaBeller AntoniaBeller commented Oct 29, 2021 •
edited
Loading

Added Prokka for genome annotation of bins.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 29, 2021 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1922b67

+| ✅ 136 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!
Details

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version mentioned in Quick Start section.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.1
  • Run at 2021-11-03 11:17:20

d4straub
d4straub approved these changes Oct 29, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
Just one little suggestion.

Comment thread conf/modules.config Outdated
@d4straub d4straub mentioned this pull request Nov 3, 2021
Closed
@AntoniaBeller AntoniaBeller merged commit c2b2633 into nf-core:dev Nov 3, 2021
@AntoniaBeller AntoniaBeller deleted the prokka branch November 3, 2021 13:15
@AntoniaBeller AntoniaBeller linked an issue Nov 5, 2021 that may be closed by this pull request
Add Prokka #243
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d4straub d4straub d4straub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Prokka

2 participants

@AntoniaBeller @d4straub