Skip to content

Add fastp to multiqc#258

Merged
d4straub merged 3 commits intonf-core:devfrom
d4straub:add-fastp-to-multiqc
Nov 22, 2021
Merged

Add fastp to multiqc#258
d4straub merged 3 commits intonf-core:devfrom
d4straub:add-fastp-to-multiqc

Conversation

@d4straub
Copy link
Copy Markdown
Collaborator

@d4straub d4straub commented Nov 22, 2021 •
edited
Loading

Closes #257

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 22, 2021 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1bc7d0e

+| ✅ 136 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!
Details

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version mentioned in Quick Start section.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.1
  • Run at 2021-11-22 18:08:04

ggabernet
ggabernet approved these changes Nov 22, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@d4straub
Copy link
Copy Markdown
Collaborator Author

d4straub commented Nov 22, 2021

Thanks!

@d4straub d4straub merged commit abe85c9 into nf-core:dev Nov 22, 2021
@d4straub d4straub deleted the add-fastp-to-multiqc branch November 22, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggabernet ggabernet ggabernet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@d4straub @ggabernet