Skip to content

Restructure depth results#299

Merged
skrakau merged 3 commits intonf-core:devfrom
skrakau:restructure_depth_results
May 13, 2022
Merged

Restructure depth results#299
skrakau merged 3 commits intonf-core:devfrom
skrakau:restructure_depth_results

Conversation

@skrakau
Copy link
Copy Markdown
Member

@skrakau skrakau commented May 13, 2022

Add extra depths folder within results/GenomeBinning/ for depth files and plots.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 732b71b

+| ✅ 146 tests passed       |+
#| ❔   1 tests were ignored |#
Details

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.3.2
  • Run at 2022-05-13 09:32:37

@skrakau skrakau requested a review from d4straub May 13, 2022 09:32
d4straub
d4straub approved these changes May 13, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all fine to me.

@skrakau skrakau merged commit 5a1f400 into nf-core:dev May 13, 2022
@skrakau skrakau deleted the restructure_depth_results branch July 22, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d4straub d4straub d4straub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skrakau @d4straub