Skip to content

Fix caching of binning input#290

Merged
skrakau merged 2 commits intonf-core:devfrom
skrakau:fix_metabat2_input_caching
Apr 4, 2022
Merged

Fix caching of binning input#290
skrakau merged 2 commits intonf-core:devfrom
skrakau:fix_metabat2_input_caching

Conversation

@skrakau
Copy link
Copy Markdown
Member

@skrakau skrakau commented Mar 31, 2022

Solves #280. When the mappings are grouped for one assembly as preparation for the binning step, different symlinks to the same assembly are given and the first of the list was used. This led to different files as input for the binning causing caching problems, although the underlying assembly is the same. Fixed by sorting the list first.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 31, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 9b41688

+| ✅ 146 tests passed       |+
#| ❔   1 tests were ignored |#
Details

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.3.2
  • Run at 2022-03-31 15:37:55

@skrakau skrakau requested a review from d4straub March 31, 2022 15:29
@skrakau skrakau force-pushed the fix_metabat2_input_caching branch from 3c91deb to 9b41688 Compare March 31, 2022 15:36
@jfy133 jfy133 mentioned this pull request Mar 31, 2022
Closed
d4straub
d4straub approved these changes Apr 1, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, perfect! As expected, sorting fixes it :)

@skrakau skrakau merged commit 51fce16 into nf-core:dev Apr 4, 2022
@skrakau skrakau mentioned this pull request Apr 8, 2022
Closed
4 tasks
@skrakau skrakau deleted the fix_metabat2_input_caching branch July 22, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d4straub d4straub d4straub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skrakau @d4straub