Conversation
Co-authored-by: Daniel Straub <[email protected]>
Post release bump
Important! Template update for nf-core/tools v2.6
Update CHANGELOG after template merge
Bowtie2 local to global alignment for ancient DNA mode for BOWTIE2_ASSEMBLY_ALIGN
Update genome commandline parameter
…-sample rather than per-contig)
Add metaBAT2 mincontig warning
|
d4straub
approved these changes
Feb 27, 2023
Collaborator
d4straub
left a comment
There was a problem hiding this comment.
That are a lot of template changes... maybe we should indeed more often do minor releases right after template updates so that the release PRs are more functional changes.
LGTM.
Comment on lines
+4
to
+7
| conda "bioconda::multiqc=1.13" | ||
| container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ? | ||
| 'https://depot.galaxyproject.org/singularity/multiqc:1.13--pyhdfd78af_0' : | ||
| 'quay.io/biocontainers/multiqc:1.13--pyhdfd78af_0' }" |
Collaborator
There was a problem hiding this comment.
modules/local/multiqc.nf uses 1.12, is is required to have 2 different versions?
Member
Author
There was a problem hiding this comment.
no, you guys still have a 'custom' MultiQC module - this one isn't used, but I've left it in the pipeline to make template merges easier :)
ggabernet
approved these changes
Feb 27, 2023
Member
ggabernet
left a comment
There was a problem hiding this comment.
Looks good to me, just had a couple of commentss
Co-authored-by: Daniel Straub <[email protected]> Co-authored-by: Gisela Gabernet <[email protected]>
This reverts commit 9821515.
Sync BUSCO_PLOT version with BUSCO after version bump
Member
Author
|
Waiting for a third review from @skrakau then we can go :) |
skrakau
reviewed
Feb 28, 2023
skrakau
reviewed
Feb 28, 2023
skrakau
reviewed
Feb 28, 2023
skrakau
reviewed
Feb 28, 2023
skrakau
reviewed
Feb 28, 2023
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: Sabrina Krakau <[email protected]>
Changes for release2.3.0
skrakau
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v2.3.0 - [XXXX/XX/XX]
AddedChangedTEMPLATE(by @jfy133, @d4straub, @skrakau)--enable_conda. Updated local modules to new conda syntax and updated nf-core modules (by @skrakau)Fixed--very-sensitivemode) to prevent soft clipping at the end of reads when running in local mode. (by @maxibor)DependenciesPR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).