Skip to content

Post release version bump and README fix#400

Merged
jfy133 merged 2 commits intodevfrom
post-red-cow-release-bump
Mar 2, 2023
Merged

Post release version bump and README fix#400
jfy133 merged 2 commits intodevfrom
post-red-cow-release-bump

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Mar 2, 2023

README fix is for the duplicated Zenodo badge

Also just noticed @prototaxites is not in the credits (but was in the CHANGELOG stuff 👍 ), so added that too

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 requested review from d4straub and skrakau March 2, 2023 10:36
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 2, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 383e818

+| ✅ 156 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-03-02 10:38:37

d4straub
d4straub approved these changes Mar 2, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

skrakau
skrakau approved these changes Mar 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@skrakau skrakau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jfy133 jfy133 merged commit 896fbfe into dev Mar 2, 2023
@jfy133 jfy133 deleted the post-red-cow-release-bump branch March 2, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skrakau skrakau skrakau approved these changes

@d4straub d4straub d4straub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jfy133 @skrakau @d4straub