Skip to content

Fixed missing MultiQC when quast or busco is skipped#47

Merged
skrakau merged 2 commits intonf-core:devfrom
skrakau:fix_missing__multiqc
May 28, 2020
Merged

Fixed missing MultiQC when quast or busco is skipped#47
skrakau merged 2 commits intonf-core:devfrom
skrakau:fix_missing__multiqc

Conversation

@skrakau
Copy link
Copy Markdown
Member

@skrakau skrakau commented May 21, 2020

The multiqc process required as input the output from quast and busco, i.e. no MultiQC report was generated when --skip_quast or --skip_busco was specified. Added .ifEmpty([]) to fix this.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/mag/tree/master/.github/CONTRIBUTING.md

@skrakau skrakau requested a review from HadrienG May 21, 2020 10:27
@skrakau skrakau requested a review from d4straub May 28, 2020 13:09
Copy link
Copy Markdown
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Actually, a comment in the change-log would be good as well.

@skrakau
Copy link
Copy Markdown
Member Author

skrakau commented May 28, 2020

@d4straub thanks, done!

@skrakau skrakau merged commit 3006ed6 into nf-core:dev May 28, 2020
@skrakau skrakau deleted the fix_missing__multiqc branch November 4, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants