Skip to content

Fixed Update description of additional Bowtie2 and SPAdes parameters …#496

Merged
jfy133 merged 2 commits intonf-core:devfrom
willros:documentation-fix
Aug 25, 2023
Merged

Fixed Update description of additional Bowtie2 and SPAdes parameters …#496
jfy133 merged 2 commits intonf-core:devfrom
willros:documentation-fix

Conversation

@willros
Copy link
Copy Markdown
Contributor

@willros willros commented Aug 25, 2023

…used in command line (issue #411)

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 25, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5990e7e

+| ✅ 156 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-25 14:07:57

d4straub
d4straub approved these changes Aug 25, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!
If you want to merge the PR yourself, you might have to join nf-core on github first, see https://nf-co.re/join#github. Otherwise post here and anone else can merge it after tests pass.

d4straub
d4straub reviewed Aug 25, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, but you might want to add your contribution to CHANGELOG.md!

@willros
Copy link
Copy Markdown
Contributor Author

willros commented Aug 25, 2023

Thanks, looks good to me! If you want to merge the PR yourself, you might have to join nf-core on github first, see https://nf-co.re/join#github. Otherwise post here and anone else can merge it after tests pass.

Someone else can merge it for now! Thanks,
William

@jfy133 jfy133 merged commit a0a5c37 into nf-core:dev Aug 25, 2023
@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Aug 25, 2023

Thanks @willros !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d4straub d4straub d4straub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@willros @jfy133 @d4straub