Skip to content

ch_cat_global_summary#574

Merged
jfy133 merged 1 commit intonf-core:devfrom
maxibor:dev
Feb 2, 2024
Merged

ch_cat_global_summary#574
jfy133 merged 1 commit intonf-core:devfrom
maxibor:dev

Conversation

@maxibor
Copy link
Copy Markdown
Member

@maxibor maxibor commented Feb 2, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 2, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 708fe39

+| ✅ 211 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   4 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file [TODO: try and test using for --host_fasta and --host_genome]
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowMag.groovy: Optionally add in-text citation tools to this list.
  • schema_lint - Input mimetype is missing or empty

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.12.1
  • Run at 2024-02-02 15:35:54

@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Feb 2, 2024

Change log update missing but otherwise simple enough !

@jfy133 jfy133 self-requested a review February 2, 2024 15:46
@jfy133 jfy133 merged commit 4594c93 into nf-core:dev Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfy133 jfy133 jfy133 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxibor @jfy133