Skip to content

Remove unused module#654

Merged
jfy133 merged 3 commits intodevfrom
remove-old-module
Aug 22, 2024
Merged

Remove unused module#654
jfy133 merged 3 commits intodevfrom
remove-old-module

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Aug 22, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133
Copy link
Copy Markdown
Member Author

jfy133 commented Aug 22, 2024

@nf-core-bot fix linting

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 22, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 70e647c

+| ✅ 306 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   5 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file [TODO: try and test using for --host_fasta and --host_genome]
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-08-22 12:40:42

@maxulysse
Copy link
Copy Markdown
Member

maxulysse commented Aug 22, 2024

check out conf/base.config

@jfy133 jfy133 merged commit 1a425b5 into dev Aug 22, 2024
@jfy133 jfy133 deleted the remove-old-module branch August 22, 2024 13:04
@jfy133
Copy link
Copy Markdown
Member Author

jfy133 commented Aug 22, 2024

Thanks @maxulysse !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxulysse maxulysse maxulysse approved these changes

@mashehu mashehu mashehu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jfy133 @maxulysse @mashehu