Merged
Conversation
44742bd to
2b167dc
Compare
jfy133
reviewed
Mar 15, 2025
Member
There was a problem hiding this comment.
Thank you for this @dialvarezs !
Looks good only two comments:
- docs/output.md needs updating
- given the file name change, does anything downstream need to be updated to accommodate this (I'm thinking bin_summary.tsv)
Member
Author
|
I updated output, and no, nothing changes downstream, because the file is the same as before, only renamed. |
Member
|
@amizeranschi is going to do a mega test of the branch (as he has a lot of interest in this as busco is underperforming on a huge dataset), and will report back - if he says he is happy with it we will merge in and do a patch release :) |
Contributor
|
This code worked fine for me with 300+ large metagenomic samples. CheckM2 seems great, BTW. It might even be worth it to set it as default, instead of BUSCO. |
jfy133
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #773.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).