Conversation
Update fastqc
Add support fastp ployg trimming
Member
Author
|
@nf-core-bot fix linting |
|
|
jfy133
commented
May 14, 2025
jfy133
commented
May 14, 2025
jfy133
commented
May 14, 2025
Member
Author
|
@nf-core-bot fix linting |
charles-plessy
approved these changes
May 20, 2025
charles-plessy
left a comment
There was a problem hiding this comment.
Looks good to me. I only had a minor question on comma addition…
Add changelog pending updates
erikrikarddaniel
approved these changes
May 22, 2025
Member
erikrikarddaniel
left a comment
There was a problem hiding this comment.
Looks good, with two small comments.
| ## A note on GTDB having too many files or using too many inodes | ||
|
|
||
| The GTDB is very large both in size and by the number of files it contains. | ||
| The uncompressed database requires >200k inodes, which can be problematic for users with limited storage resources. |
Member
There was a problem hiding this comment.
Is perhaps "files" better than "inodes" here? Easier to understand for the less technically savvy even if slightly less correct. Also below.
Co-authored-by: Daniel Lundin <[email protected]>
jfy133
commented
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).