Skip to content

Skip short and long read qc#829

Merged
jfy133 merged 13 commits intonf-core:devfrom
erikrikarddaniel:skip-qc
Jun 20, 2025
Merged

Skip short and long read qc#829
jfy133 merged 13 commits intonf-core:devfrom
erikrikarddaniel:skip-qc

Conversation

@erikrikarddaniel
Copy link
Copy Markdown
Member

@erikrikarddaniel erikrikarddaniel commented Jun 13, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Add --skip_shortread_qc and --skip_longread_qc to allow input of preprocessed reads. Part of issue #806 , but much more needed to cover that.

Comment thread nextflow_schema.json Outdated
Copy link
Copy Markdown
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small docs things, you can merge once result

Comment thread nextflow_schema.json Outdated
Comment thread nextflow_schema.json Outdated
Comment thread nextflow_schema.json Outdated
Comment thread CHANGELOG.md Outdated
@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Jun 18, 2025

Small update, local test results

  • Short read test looks good
  • Long read running

I note that in both cases both FASTQCs/NANOPLOTs run - is that to be expected?

@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Jun 20, 2025

Code looks good! Testing again...

@jfy133
Copy link
Copy Markdown
Member

jfy133 commented Jun 20, 2025

  • nextflow run ../main.nf -profile test_hybrid,docker --outdir ./results --skip_shortread_qc --skip_longread_qc --ansi-log false --> no FILTERED fastqc/nonplot
  • nextflow run ../main.nf -profile test_hybrid,docker --outdir ./results --skip_shortread_qc -ansi-log false --> no filtered FASTQC / yes filtered nonplot
  • nextflow run ../main.nf -profile test_hybrid,docker --outdir ./results --skip_longread_qc -ansi-log false --> no Nanoplot / Yes filtered fastqcx
  • nextflow run ../main.nf -profile test_hybrid,docker --outdir ./results -ansi-log false

(ffs really need to make proper nf-tests...)

  • nextflow run ../main.nf -profile test,docker --outdir ./results -ansi-log false --> three trimmed
  • nextflow run ../main.nf -profile test,docker --outdir ./results -ansi-log false --skip_shortread_qc --> no trimmed
  • nextflow run ../main.nf -profile test_host_rm,docker --outdir ./results -ansi-log false --sk ip_shortread_qc --> DO run fastqc_trimmed because host removal
  • nextflow run ../main.nf -profile test_longread,docker --outdir ./results -ansi-log false --s kip_longread_qc didn't run nanoplot raw at all (went striaght to assembly... maybe scheduling reasons... will see if will execute after assembly) --> it did
  • nextflow run ../main.nf -profile test_longread,docker --outdir ./results -ansi-log false --> runs timmed
  • nextflow run ../main.nf -profile test_longread,docker --outdir ./results -ansi-log false --skip_longread_qc --host_fasta --> run trimmed even if skip_qc, because host removal

We are good to go - thank you very much @erikrikarddaniel !

@jfy133 jfy133 merged commit 4c74f14 into nf-core:dev Jun 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants