Merged
Conversation
prototaxites
approved these changes
Aug 13, 2025
Contributor
prototaxites
left a comment
There was a problem hiding this comment.
LGTM!
You were talking about adding some kind of tunable ext option to this and similar modules - is it worth making the 0.8 tunable here with a parameter, even if that proposal isn't supported for all of nf-core?
Member
Author
|
Sorry, I didn't see your comment until I had merged. I decided not to make this tunable both because I didn't want to go through the bureaucracy of updating the nf-core module but also as it actually felt a bit overengineered for myself. |
Member
|
A bit late but @erikrikarddaniel could we have a follow up PR with a change log update please? otherwise is fine! |
Member
Author
|
It's in the change log, under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).This updates the bbmap/bbnorm module to the current nf-core version plus updates it to give the process only 0.8 of the memory assigned to the task.