Only error on bin length filter if there are bins#888
Merged
prototaxites merged 10 commits intonf-core:devfrom Oct 24, 2025
Merged
Only error on bin length filter if there are bins#888prototaxites merged 10 commits intonf-core:devfrom
prototaxites merged 10 commits intonf-core:devfrom
Conversation
Release: 5.0.0 Green Squirrel
Added error handling for cases with no bins passing the size filter.
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.3.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
Contributor
Author
|
@nf-core-bot fix linting |
jfy133
approved these changes
Oct 24, 2025
Member
jfy133
left a comment
There was a problem hiding this comment.
Tested by breaking the megahit command, and error seen in dev is now removed in this branch, so LGTM tiny change to CHANGELOG and can merge :)
Thanks @prototaxites !
Co-authored-by: James A. Fellows Yates <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added error handling for cases with no bins passing the size filter.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).