Change deprecated Channel and make closures parameters explicit#932
Merged
dialvarezs merged 9 commits intonf-core:devfrom Nov 17, 2025
Merged
Change deprecated Channel and make closures parameters explicit#932dialvarezs merged 9 commits intonf-core:devfrom
Channel and make closures parameters explicit#932dialvarezs merged 9 commits intonf-core:devfrom
Conversation
Channel() by channel() and make parameters explicit in closures.Channel() by channel() and make closures parameters explicit
Channel() by channel() and make closures parameters explicitChannel() and make closures parameters explicit
Channel() and make closures parameters explicitChannel and make closures parameters explicit
jfy133
approved these changes
Nov 17, 2025
Member
jfy133
left a comment
There was a problem hiding this comment.
Other than the one line I'm unsure about, looks good!
Co-authored-by: James A. Fellows Yates <[email protected]>
Member
|
@dialvarezs we have a conflict, please resolve it and ping me and I'll do one last quick check and then I tihnk you can merge :) |
Member
Author
|
@jfy133 It's solved now |
Member
|
@dialvarezs I think you're missing the comment about bbnorm and the interleaved thing (on my phone tho, so if it'd there and GitHub app being poopy please shout) |
Member
|
It was being poopy, loaded now! Looking again |
Member
|
You can merge @dialvarezs ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a style-only pr.
In Nextflow 25.10
Channelusage was deprecated, because it's used now for typing, so I changed all the usages in local workflows tochannel.I also made closure parameters explicit (this was also beign flagged by the LSP)
And make other minor modifications like splitting looong lines, and a minor refactoring in the assembly workflow.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).