Skip to content

Workaround around for CheckM2 database downloading being blocked by Zenodo#966

Merged
jfy133 merged 2 commits intodevfrom
workaround-checkm2-dl
Jan 20, 2026
Merged

Workaround around for CheckM2 database downloading being blocked by Zenodo#966
jfy133 merged 2 commits intodevfrom
workaround-checkm2-dl

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Jan 20, 2026

As @dialvarezs discovered here: https://nfcore.slack.com/archives/CE9MS66BS/p1768218671915759

Zenodo is blocking aria2c downloads, which is what our current module uses.

This PR provides a workaround using the (in some cases much slower!!) method of Nextflow's native downloading system.

Note that due to this switch to using the UNTAR module, I also had to update the CheckM module to also locate the file .dmnd itself, a la the bowtie2 modules etc.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 marked this pull request as ready for review January 20, 2026 07:39
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 20, 2026 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 9f83855

+| ✅ 381 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   6 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file [TODO: try and test using for --host_fasta and --host_genome]
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in nextflow.config: Specify any additional parameters here

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.1
  • Run at 2026-01-20 09:12:49

@jfy133
Copy link
Copy Markdown
Member Author

jfy133 commented Jan 20, 2026

Thanks @maxulysse !

@jfy133
Copy link
Copy Markdown
Member Author

jfy133 commented Jan 20, 2026

And @dialvarezs !

@jfy133 jfy133 merged commit 4c7bfad into dev Jan 20, 2026
23 checks passed
@jfy133 jfy133 deleted the workaround-checkm2-dl branch January 20, 2026 10:41
@dialvarezs dialvarezs mentioned this pull request Apr 2, 2026
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxulysse maxulysse maxulysse approved these changes

@dialvarezs dialvarezs dialvarezs approved these changes

@d4straub d4straub Awaiting requested review from d4straub d4straub is a code owner

@prototaxites prototaxites Awaiting requested review from prototaxites prototaxites is a code owner

@muabnezor muabnezor Awaiting requested review from muabnezor muabnezor is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jfy133 @maxulysse @dialvarezs