Include MetaBinner/SemiBin2 as inputs to DASTool#962
Conversation
There was a problem hiding this comment.
Thank you @AlexHoratio !
I've not tested, but looks simple enough to me. I'll let someone else from @nf-core/nf-core-mag to double check :)
|
of the tests:
|
|
This looks fine to me also, but I just want to double-check - are the contig headers of the bins from these new binners compatible with DAS_Tool? Some binners for whatever reason rename contigs, but these bin refinement tools need the original contig names to remain in place. |
I just double-checked some of my outputs, and I can't find any evidence of the contigs being renamed, and it does seem to mix with DASTool appropriately. Also, that snapshot update test is still failing... I think that's my fault for trying to run it on my under-powered local machine. I'll try it again in a moment. |
|
Don't worry @AlexHoratio the failing test isn't you Zenodo is 403ing for some reason when downloading the CheckM2 database.. not to do with you I think :) |
It seems that Zenodo is blocking aria2 UA 🙃. It doesn't work for me either, but it does when changing UA, e.g. |
|
@AlexHoratio sorry taken so long to get to this. We refactored somewhat the DAS_Tool steps in another PR, so there were some merge conflicts I've tried to resolve. Please have a look to make sure I didn't make sure Otherwise I think the nf-test snapshot may still need updating, but we w ill see (checkM issues should be resolved now!) |
|
Awesome, well that is a good refactor 😊 I believe the test_assembly_input snapshot should now be updated again. |
|
Is that something you have capacity to do, or should one someone take over @AlexHoratio ? |
|
If you just need me to test the pipeline on some real data and see if this PR currently works, I have just done that, and it appears to do so.. all binners still occur appropriately in DASTool outputs. Anything else may lie beyond my Nextflow know-how 🥲 |
|
Works for me! Thank you @AlexHoratio ! LGTM! |
Happy Yuletide, developers of nf-core! 😊
As a gift I bring you this PR: MetaBinner/SemiBin2 should be included as inputs to DASTool when available. I believe this fixes it by replicating the existing pattern for other binners (just tested on my own data, appears to work).
PR checklist