Skip to content

Add PR labeller workflow to report size of PRs#972

Merged
jfy133 merged 2 commits intodevfrom
add-pr-labeller-workflow
Feb 2, 2026
Merged

Add PR labeller workflow to report size of PRs#972
jfy133 merged 2 commits intodevfrom
add-pr-labeller-workflow

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Feb 2, 2026

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 marked this pull request as ready for review February 2, 2026 11:08
@github-actions github-actions Bot added the size/s label Feb 2, 2026
@nf-core-bot
Copy link
Copy Markdown
Member

nf-core-bot commented Feb 2, 2026

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 2, 2026 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ca45d13

+| ✅ 382 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   7 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 5.4.0
  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file [TODO: try and test using for --host_fasta and --host_genome]
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in nextflow.config: Specify any additional parameters here

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.1
  • Run at 2026-02-02 11:13:35

@jfy133
Copy link
Copy Markdown
Member Author

jfy133 commented Feb 2, 2026

@nf-core-bot fix linting

prototaxites
prototaxites reviewed Feb 2, 2026
View reviewed changes
Comment thread .github/workflows/labeler.yml Outdated
Please make sure you are NOT addressing multiple issues with one PR.
Note this PR might be rejected due to its size.
github_api_url: 'https://api.github.com'
files_to_ignore: ''
Copy link
Copy Markdown
Contributor

@prototaxites prototaxites Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth making this ignore the "linguist-generated" nf-core modules and subworkflows file changes that are listed in .gitattributes (https://github.com/nf-core/mag/blob/main/.gitattributes)?

I would like to think that changes to external nf-core code should not count towards PR size labelling.

Copy link
Copy Markdown
Member Author

@jfy133 jfy133 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shall see! This is a part of the experiment! :)

FriederikeHanssen
FriederikeHanssen approved these changes Feb 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Report back how well this works so we can add it to the template

@jfy133 jfy133 merged commit 223ef48 into dev Feb 2, 2026
10 checks passed
@jfy133 jfy133 mentioned this pull request Feb 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prototaxites prototaxites prototaxites left review comments

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

@d4straub d4straub Awaiting requested review from d4straub d4straub is a code owner

@muabnezor muabnezor Awaiting requested review from muabnezor muabnezor is a code owner

@dialvarezs dialvarezs Awaiting requested review from dialvarezs dialvarezs is a code owner

Assignees

No one assigned

Labels

size/s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jfy133 @nf-core-bot @FriederikeHanssen @prototaxites