Skip to content

fix failing pytest for lint after samtools topic conversion#4026

Merged
mashehu merged 9 commits intonf-core:devfrom
mashehu:fix-test-for-subworkflows
Feb 6, 2026
Merged

fix failing pytest for lint after samtools topic conversion#4026
mashehu merged 9 commits intonf-core:devfrom
mashehu:fix-test-for-subworkflows

Conversation

@mashehu
Copy link
Copy Markdown
Contributor

@mashehu mashehu commented Feb 2, 2026

decided to comment out the counting until we have converted all modules, so we don't need to come back to this every time one changes

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.40%. Comparing base (33d2a9c) to head (3784be6).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/components/components_test.py 28.57% 10 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a TODO comment to add this line back with the correct counting once all modules add converted.
Apart form this LGTM!

@mashehu mashehu force-pushed the fix-test-for-subworkflows branch from 6a4317c to 3784be6 Compare February 6, 2026 13:56
@mashehu mashehu merged commit 5a277ed into nf-core:dev Feb 6, 2026
114 checks passed
mashehu added a commit to mashehu/tools that referenced this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants