switch to gitlab module to test with old version syntax#4126
Merged
mashehu merged 4 commits intonf-core:devfrom Mar 19, 2026
Merged
switch to gitlab module to test with old version syntax#4126mashehu merged 4 commits intonf-core:devfrom
mashehu merged 4 commits intonf-core:devfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
beatrizsavinhas
approved these changes
Mar 19, 2026
Contributor
beatrizsavinhas
left a comment
There was a problem hiding this comment.
Looks good to me! And great that you made the test more specific too! 🌟
Co-authored-by: Beatriz Vinhas <[email protected]> Co-authored-by: Matthias Hörtenhuber <[email protected]>
Contributor
Author
|
@nf-core-bot fix linting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4125
bioawkwas recently switched to the new topic syntax, but we used this module to check for the old sytnax.To avoid trying to find modules without topics in the main nf-core modules repo, I instead test the topic version linting against out test repo on gitlab, which has more stable modules (i.e. they only change if we need to).
This PR also adds a helper function to install a module from the branch on gitlab that has modules with nf-test to avoid getting more linting warnings than necessary.