Skip to content

Lint meta variable names#4129

Merged
mahesh-panchal merged 10 commits intonf-core:devfrom
mahesh-panchal:feat/module-lint-meta
Apr 1, 2026
Merged

Lint meta variable names#4129
mahesh-panchal merged 10 commits intonf-core:devfrom
mahesh-panchal:feat/module-lint-meta

Conversation

@mahesh-panchal
Copy link
Copy Markdown
Member

@mahesh-panchal mahesh-panchal commented Mar 23, 2026 •
edited
Loading

Description

Adds linting for meta variable names.

Related issue

nf-core/website#4080 Enforces the meta map naming scheme.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@mahesh-panchal
Copy link
Copy Markdown
Member Author

mahesh-panchal commented Mar 23, 2026

@nf-core-bot changelog

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 23, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.47%. Comparing base (0345e8b) to head (730ba51).
⚠️ Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/modules/lint/main_nf.py 82.75% 5 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mashehu
mashehu reviewed Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a unit test?
If our test setup is too complicated, I can give it a try.

Comment thread nf_core/modules/lint/main_nf.py
@mahesh-panchal
Copy link
Copy Markdown
Member Author

mahesh-panchal commented Mar 23, 2026

I think I found the file. I can try adding some tests.

@mahesh-panchal
Copy link
Copy Markdown
Member Author

mahesh-panchal commented Mar 24, 2026

Tests added

@mahesh-panchal mahesh-panchal requested a review from mashehu March 27, 2026 08:40
@mashehu mashehu added this to the 4.0.0 milestone Mar 31, 2026
JulianFlesch
JulianFlesch reviewed Apr 1, 2026
View reviewed changes
Comment thread nf_core/modules/lint/main_nf.py Outdated
@mahesh-panchal mahesh-panchal merged commit 12a4dec into nf-core:dev Apr 1, 2026
107 of 112 checks passed
@mahesh-panchal mahesh-panchal deleted the feat/module-lint-meta branch April 1, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulianFlesch JulianFlesch JulianFlesch approved these changes

@mashehu mashehu Awaiting requested review from mashehu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mahesh-panchal @mashehu @JulianFlesch @nf-core-bot