Skip to content

Ensure release linting happens on branch named main#4121

Merged
mashehu merged 2 commits intodevfrom
allow-release-linting-on-main-branch
Mar 20, 2026
Merged

Ensure release linting happens on branch named main#4121
mashehu merged 2 commits intodevfrom
allow-release-linting-on-main-branch

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Mar 16, 2026

To fix what I noticed here: https://nfcore.slack.com/archives/CQY2U5QU9/p1773517450944579

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.46%. Comparing base (7030b9c) to head (b15d48d).
⚠️ Report is 2 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jfy133 jfy133 requested review from mashehu and mirpedrol and removed request for mashehu March 16, 2026 12:02
Copy link
Copy Markdown
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, thought we checked all instances of master back then.... thanks for the fix

@jfy133
Copy link
Copy Markdown
Member Author

jfy133 commented Mar 16, 2026

Related: #3939

@mashehu mashehu force-pushed the allow-release-linting-on-main-branch branch from 77d2b37 to b15d48d Compare March 20, 2026 09:56
@mashehu mashehu merged commit 573f105 into dev Mar 20, 2026
112 checks passed
@mashehu mashehu deleted the allow-release-linting-on-main-branch branch March 20, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants